サムネイル画像の表示を修正 #4504
Merged
サムネイル画像の表示を修正 #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4504-prod.traq-preview.trapti.tech/ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4504 +/- ##
======================================
Coverage 8.82% 8.82%
======================================
Files 670 670
Lines 29448 29445 -3
Branches 522 522
======================================
Hits 2599 2599
+ Misses 26843 26840 -3
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4502
やったこと
widthの指定されていない flex 扱いのdivタブ内部でflex-shrink: 0;が適用されていたのが今回の原因だと考えましたdivを使わなくても実装できるように CSS の書く位置を変更しましたflex-shrink: 0;自体あまり書かなくてもいいのかな〜とは思ったので、ここはご意見を伺いたいです:not(:last-child)を使って適用されていた margin を、 gap に置き換えることもしました